Support Prism::Translation::Parser35 for Ruby 3.5 parser
#370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
6c19492 to
2685ff7
Compare
2685ff7 to
a4b5f25
Compare
a4b5f25 to
1b7ec6d
Compare
prism with the translation parser on Ruby >= 3.4Prism::Translation::Parser35 for Ruby 3.5 parser
koic
reviewed
Mar 21, 2025
lib/rubocop/ast/processed_source.rb
Outdated
| @@ -35,25 +35,21 @@ class ProcessedSource # rubocop:disable Metrics/ClassLength | |||
| INVALID_LEVELS = %i[error fatal].freeze | |||
| private_constant :INVALID_LEVELS | |||
|
|
|||
| PARSER_ENGINES = %i[parser_whitequark parser_prism].freeze | |||
| PARSER_ENGINES = %i[automatic parser_whitequark parser_prism].freeze | |||
There was a problem hiding this comment.
The term "automatic" might not be the most suitable. "default" might be more preferable.
Suggested change
| PARSER_ENGINES = %i[automatic parser_whitequark parser_prism].freeze | |
| PARSER_ENGINES = %i[default parser_whitequark parser_prism].freeze |
There was a problem hiding this comment.
I'm not sure if default is actually better but I also don't like automatic particularly.
In the original version, I opted to simply use nil to signify this instead. But that has backwards compatibility concerns, where it might choose prism when it previously wouldn't when the user doesn't pass parser_engine to the method at all.
I changed it to :default.
There was a problem hiding this comment.
Yeah, I'm not sure if default is the most suitable choice, but it's a simple term. It's understood that this is a parameter for compatibility and it would be nice if a better name were suggested :-)
There was a problem hiding this comment.
Yup, most users won't have to configure this. So I wouldn't think too much about it.
1b7ec6d to
c2ea41b
Compare
c2ea41b to
8d4ad5a
Compare
koic
reviewed
Mar 21, 2025
docs/modules/ROOT/pages/index.adoc
Outdated
| @@ -109,10 +109,14 @@ for the `:prism_result` keyword argument. Otherwise, the source code is parsed. | |||
|
|
|||
| [source,ruby] | |||
| ---- | |||
| # Using the Parser gem with `prism_result: nil` is the default, meaning the source code is parsed. | |||
| # Using the Parser gem with `prism_result: nil` is the default, meaning the source code is parsed until `ruby_version` is 3.4. | |||
There was a problem hiding this comment.
Suggested change
| # Using the Parser gem with `prism_result: nil` is the default, meaning the source code is parsed until `ruby_version` is 3.4. | |
| # Using the Parser gem with `prism_result: nil` is the default, meaning the source code is parsed until `ruby_version` is 3.4. |
There was a problem hiding this comment.
My bad, butchered the copy-paste
koic
reviewed
Mar 21, 2025
lib/rubocop/ast/processed_source.rb
Outdated
| # The Parser gem does not support Ruby 3.5 or later. | ||
| # It is also not fully compatible with Ruby 3.4 but for | ||
| # now respects using parser for backwards compatibility. | ||
| def best_parser_engine(ruby_version) |
There was a problem hiding this comment.
Can you rename it to the following?
Suggested change
| def best_parser_engine(ruby_version) | |
| def default_parser_engine(ruby_version) |
There was a problem hiding this comment.
Sure, that name makes good sense now
It chooses the prism parser automatically when Ruby 3.5 is selected. In RuboCop, The `ParserEngine` must be set to `automatic` to make use of this. In the future, the prism gem can also be chosen for Ruby 3.4 Co-authored-by: Koichi ITO <koic.ito@gmail.com>
8d4ad5a to
c17948b
Compare
Prism::Translation::Parser35 for Ruby 3.5 parserPrism::Translation::Parser35 for Ruby 3.5 parser
|
🚀 |
|
Thanks for working with me on this @koic |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 24, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 24, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 24, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 24, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
8 tasks
|
I openend rubocop/rubocop#14025 since I already had half of it in rubocop/rubocop#14010 to make it work. Hope that's ok. |
|
Of course! |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Mar 25, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Mar 25, 2025
This builds on top of rubocop/rubocop-ast#370, to let `rubocop-ast` choose the parser engine automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step further towards rubocop/rubocop#13617
In RuboCop, the parser engine in the default config can be set to
default, and with Ruby 3.5, RuboCop will then automatically choose prism to do its job.More discussion and considerations in #371