Skip to content

Conversation

sgatto
Copy link
Member

@sgatto sgatto commented Nov 14, 2023

We should remove the SetStartingLpBasisInt function in order to be more consistent with the wishes of google/ortools.
This pr aims to delete SetStartingLpBasisInt and GetStartingLpBasisInt

@sgatto sgatto requested a review from flomnes November 14, 2023 12:42
@sgatto sgatto requested review from flomnes and removed request for flomnes November 14, 2023 16:56
@@ -1307,7 +1354,6 @@ TEST(XpressInterface, CallbackThrowsException) {
} // namespace operations_research

int main(int argc, char** argv) {
InitGoogle(argv[0], &argc, &argv, true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It brakes the standard googletest arguments apparently without adding functionalities that are useful for us

@sgatto sgatto merged commit 17ed6aa into feature/xpress_only_RTE Nov 17, 2023
@flomnes flomnes deleted the feature/change_SetStartingLpBasis branch November 17, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants