You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Langfuse(==v2.60.4): I encountered an issue where the error "Set of Tasks/Futures is empty" was raised. To resolve this, I added a condition to handle that case.
Langsmith(with litellm==v1.66.3): I experienced an infinite wait issue, which turned out to be caused by periodic flushing. To mitigate this, I added a TTL (time-to-live) to limit the waiting time.
PR Type
Bug fix, Enhancement
Description
Add timeout to asyncio.wait when callbacks are enabled
Prevents infinite wait by limiting to 30 seconds
Handles empty task set to avoid errors
Changes walkthrough 📝
Relevant files
Bug fix
cli.py
Add timeout and empty-task check to event queue wait
pr_agent/cli.py
Added a 30-second timeout to asyncio.wait for callback tasks
Added a check to ensure the task list is not empty before waiting
Prevents errors and infinite waits during event queue flushing
The 30-second timeout is hardcoded. Consider making this configurable through settings to allow users to adjust based on their specific environment needs.
✅ Handle timeout resultsSuggestion Impact:The commit implemented exactly what was suggested - capturing the done and pending tasks from asyncio.wait() and adding a warning log when tasks exceed the timeout
code diff:
- await asyncio.wait(tasks, timeout=30)+ done, pending = await asyncio.wait(tasks, timeout=30)+ if pending:+ get_logger().warning(f"{len(pending)} callback tasks did not complete within timeout")
Handle the case where tasks don't complete within the timeout. Currently, if tasks exceed the timeout, they continue running but the program proceeds, which could lead to unexpected behavior. Consider adding a warning log or handling incomplete tasks.
tasks = [task for task in asyncio.all_tasks() if task is not asyncio.current_task()]
if tasks:
- await asyncio.wait(tasks, timeout=30)+ done, pending = await asyncio.wait(tasks, timeout=30)+ if pending:+ get_logger().warning(f"{len(pending)} callback tasks did not complete within timeout")
[Suggestion processed]
Suggestion importance[1-10]: 7
__
Why: The suggestion improves robustness by warning if callback tasks do not complete within the timeout, which helps with debugging and monitoring but does not address a critical bug or security issue.
Medium
Update
Author self-review: I have reviewed the PR code suggestions, and addressed the relevant ones.
dst03106
changed the title
fix: add timeout to asyncio.wait when callback is enabled
fix: add timeout to asyncio.wait during CLI execution to avoid hanging when callback is enabled
May 13, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
When integrating with logging observability platforms:
PR Type
Bug fix, Enhancement
Description
asyncio.waitwhen callbacks are enabledChanges walkthrough 📝
cli.py
Add timeout and empty-task check to event queue waitpr_agent/cli.py
asyncio.waitfor callback tasks