Skip to content

fix: update Docker base image to slim version and install required de… #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2025
Merged

fix: update Docker base image to slim version and install required de… #1762

merged 2 commits into from
May 11, 2025

Conversation

mrT23
Copy link
Collaborator

@mrT23 mrT23 commented May 11, 2025 •
edited by qodo-merge-for-open-source bot
Loading

User description

…pendencies

PR Type

enhancement

Description

  • Switches Docker base image to python:3.12.10-slim for reduced size

  • Installs git and curl with minimal dependencies in Docker image

  • Cleans up apt cache to reduce image size

Changes walkthrough 📝

Relevant files
Enhancement
Dockerfile.github_action
Optimize Dockerfile with slim image and minimal dependencies

Dockerfile.github_action

  • Changed base image to python:3.12.10-slim for a smaller footprint
  • Added installation of git and curl using apt with no extra recommends
  • Added cleanup of apt cache and lists to minimize image size
    		• +3/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-for-open-source Qodo Merge for Open Source
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-for-open-source Qodo Merge for Open Source
    Copy link
    Contributor

    qodo-merge-for-open-source bot commented May 11, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    ✅ Use consistent package manager
    Suggestion Impact:The commit changed the Dockerfile to use apt-get consistently instead of mixing apt and apt-get commands, exactly as suggested

    code diff:

    -RUN apt update && apt install --no-install-recommends -y git curl && apt-get clean && rm -rf /var/lib/apt/lists/*
+RUN apt-get update && apt-get install --no-install-recommends -y git curl && apt-get clean && rm -rf /var/lib/apt/lists/*

    Use apt-get consistently instead of mixing apt and apt-get. The apt command is
    meant for interactive use while apt-get is more suitable for scripts and
    Dockerfiles.

    Dockerfile.github_action [3]

    -RUN apt update && apt install --no-install-recommends -y git curl && apt-get clean && rm -rf /var/lib/apt/lists/*
+RUN apt-get update && apt-get install --no-install-recommends -y git curl && apt-get clean && rm -rf /var/lib/apt/lists/*

    [Suggestion processed]

    Suggestion importance[1-10]: 7

    __

    Why: The suggestion correctly identifies the inconsistent use of apt and apt-get commands. Using apt-get consistently is better for Dockerfiles as it's designed for scripting environments, while apt is more for interactive use. This improves maintainability and follows best practices.

    		Medium
    • Update
    • Author self-review: I have reviewed the PR code suggestions, and addressed the relevant ones.

    qodo-merge-for-open-source[bot]
    qodo-merge-for-open-source bot reviewed May 11, 2025
    View reviewed changes
    @mrT23 @qodo-merge-for-open-source
    Update Dockerfile.github_action
    4210262 
    Co-authored-by: qodo-merge-pro-for-open-source[bot] <189517486+qodo-merge-pro-for-open-source[bot]@users.noreply.github.com>
    @mrT23 mrT23 merged commit eb11381 into main May 11, 2025
    2 checks passed
    @mrT23 mrT23 deleted the tr/docker_action branch May 11, 2025 14:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qodo-merge-for-open-source qodo-merge-for-open-source[bot] qodo-merge-for-open-source[bot] left review comments

    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @mrT23