fix:correct typo in logger parameter from 'artifacts' to 'artifact' #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
mrT23
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
The original PR was rejected due to formatting changes, so I submitted a new one.
I think this was caused by the auto-formatting feature in my IDE.
This PR fixes a minor typo in a debug logging call to ensure the logger behaves as expected.
Fixed a typo in the get_logger().debug(...) call: changed artifacts= to artifact=.
The logger expects the parameter to be named artifact, and using the wrong keyword can cause logs to be silently ignored or raise runtime errors.
This fix ensures that debugging output is correctly captured and visible during development.
PR Type
Bug fix
Description
Fixed typo in logger debug call parameter name.
Ensures correct logging of relevant configs.
Changes walkthrough 📝
pr_description.py
Correct logger debug parameter name for configspr_agent/tools/pr_description.py