Skip to content

Use slim Docker image and install git and curl dependencies #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

Use slim Docker image and install git and curl dependencies #1738

merged 2 commits into from
May 2, 2025

Conversation

mrT23
Copy link
Collaborator

@mrT23 mrT23 commented May 2, 2025 •
edited by qodo-merge-for-open-source bot
Loading

PR Type

enhancement

Description

  • Switch to Python slim Docker image for smaller footprint

  • Install git and curl dependencies in Docker image

  • Optimize Docker build by removing apt cache after install

Changes walkthrough 📝

Relevant files
Enhancement
Dockerfile
Switch to slim image and add essential dependencies           

docker/Dockerfile

  • Changed base image to python:3.12.10-slim for reduced size
  • Added installation of git and curl using apt
  • Cleaned up apt cache to minimize image size
    		• +3/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-for-open-source Qodo Merge for Open Source
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-for-open-source Qodo Merge for Open Source
    Copy link
    Contributor

    qodo-merge-for-open-source bot commented May 2, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    ✅ Improve apt commands
    Suggestion Impact:The commit partially implemented the suggestion by adding apt-get clean to reduce the image size, but did not change apt to apt-get or add the -qq flag

    code diff:

    -RUN apt update && apt install --no-install-recommends -y git curl && rm -rf /var/lib/apt/lists/*
+RUN apt update && apt install --no-install-recommends -y git curl && apt-get clean && rm -rf /var/lib/apt/lists/*

    Add the -qq flag to apt update and use apt-get install with -y flag before
    --no-install-recommends to ensure non-interactive installation. Also, add
    apt-get clean to further reduce the image size.

    docker/Dockerfile [3]

    -RUN apt update && apt install --no-install-recommends -y git curl && rm -rf /var/lib/apt/lists/*
+RUN apt-get update -qq && apt-get install -y --no-install-recommends git curl && apt-get clean && rm -rf /var/lib/apt/lists/*

    [Suggestion has been applied]

    Suggestion importance[1-10]: 5

    __

    Why: The suggestion correctly applies Dockerfile best practices by adding -qq for quieter updates, using apt-get which is generally preferred for scripting, and adding apt-get clean to further reduce image size. These are moderate improvements for maintainability and image optimization.

    		Low
    • Update
    • Author self-review: I have reviewed the PR code suggestions, and addressed the relevant ones.

    @mrT23 mrT23 merged commit 8bb207f into main May 2, 2025
    2 checks passed
    @mrT23 mrT23 deleted the tr/docker_slim branch May 2, 2025 06:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @CodiumAI-Agent CodiumAI-Agent CodiumAI-Agent approved these changes

    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @mrT23 @CodiumAI-Agent