ehance: github pr review comment dispaly more information about linter reference #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reviewbot-x canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
==========================================
- Coverage 30.33% 29.92% -0.41%
==========================================
Files 29 30 +1
Lines 3557 3622 +65
==========================================
+ Hits 1079 1084 +5
- Misses 2346 2406 +60
Partials 132 132 ☔ View full report in Codecov by Sentry. |
389360e to
e7ef646
Compare
CarlJi
reviewed
Nov 3, 2024
config/config.go
Outdated
| @@ -294,11 +298,26 @@ func (c Config) GetLinterConfig(org, repo, ln string) Linter { | |||
| } | |||
|
|
|||
| // GetCompiledIssueReferences returns the compiled issue references config for the given linter name. | |||
| func (c Config) GetCompiledIssueReferences(linterName string) []CompiledIssueReference { | |||
| func (c Config) GetCompiledIssueReferences(ctx context.Context, linterName string, githubClient *github.Client) []CompiledIssueReference { | |||
There was a problem hiding this comment.
githubClient 跟 config 耦合在一起不合适
978b93f to
5bcd1cf
Compare
5bcd1cf to
b9308a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect
Folding
Unfolding