feat: support kubenertes runner #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reviewbot-x canceled.
|
ec6a33f to
20dc1c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
==========================================
- Coverage 35.75% 32.91% -2.84%
==========================================
Files 27 28 +1
Lines 2358 2561 +203
==========================================
Hits 843 843
- Misses 1390 1590 +200
- Partials 125 128 +3 ☔ View full report in Codecov by Sentry. |
20dc1c7 to
9084bab
Compare
CarlJi
reviewed
Oct 17, 2024
| k.script = scriptContent | ||
|
|
||
| // create default config | ||
| // Note(wwcchh0123): support unmarshalling YAML into structures in the future |
CarlJi
reviewed
Oct 17, 2024
| } else if len(paths) == 1 { | ||
| srcPath, dstPath = paths[0], paths[0] | ||
| } else { | ||
| return nil, fmt.Errorf("invalid copy ssh key format: %s", cfg.DockerAsRunner.CopySSHKeyToContainer) |
CarlJi
reviewed
Oct 17, 2024
| }) | ||
| } | ||
|
|
||
| createdjob, err := k.Cli.BatchV1().Jobs(cfg.KubernetesAsRunner.Namespace).Create(ctx, job, metav1.CreateOptions{}) |
CarlJi
reviewed
Oct 17, 2024
| return nil, err | ||
| } | ||
|
|
||
| podName := k.getJobNameWithPrefix(ctx, cfg.KubernetesAsRunner.Namespace, createdjob.Name) |
CarlJi
reviewed
Oct 17, 2024
| log := lintersutil.FromContext(ctx) | ||
|
|
||
| // create command script on pod | ||
| cmd := exec.CommandContext(ctx, "kubectl", "exec", "-n", namespace, podName, "-c", containerName, "--", "bash", "-c", fmt.Sprintf("echo '%s' > %s/script.sh && chmod +x %s/script.sh", commandStr, workDir, workDir)) |
CarlJi
reviewed
Oct 17, 2024
| } | ||
| s.KubenertesRunner = k8sRunner | ||
| } | ||
| go func() { |
There was a problem hiding this comment.
这个本质是检查是否有权限，是个简单操作，不应该异步。
docker 那里异步，是因为下载镜像是耗时操作，且容易出问题，所以里面有个多次尝试。
CarlJi
reviewed
Oct 17, 2024
| if err != nil { | ||
| log.Fatalf("failed to init kube runner: %v", err) | ||
| } | ||
| s.KubenertesRunner = k8sRunner |
There was a problem hiding this comment.
这里会对server 结构的结构会造成变动，方法名应该有所体现，checkKubenertes 不合适了。
CarlJi
reviewed
Oct 17, 2024
| @@ -404,6 +441,9 @@ func (s *Server) handle(ctx context.Context, event *github.PullRequestEvent) err | |||
| if linterConfig.DockerAsRunner.Image != "" { | |||
| r = s.dockerRunner | |||
| } | |||
| if linterConfig.KubernetesAsRunner.Image != "" { | |||
There was a problem hiding this comment.
这里是多个条件选择一个，看来这块的代码改为 switch 更合适
CarlJi
reviewed
Oct 17, 2024
| podName := k.getJobNameWithPrefix(ctx, cfg.KubernetesAsRunner.Namespace, createdjob.Name) | ||
| namespace := cfg.KubernetesAsRunner.Namespace | ||
|
|
||
| // copy ssh to pod |
CarlJi
reviewed
Oct 17, 2024
| type KubernetesAsRunner struct { | ||
| Namespace string `json:"namespace"` | ||
| Image string `json:"image"` | ||
| SSHKeyMount string `json:"sshkeyMount,omitempty"` |
|
link #313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.