Skip to content

Conversation

wwcchh0123
Copy link
Contributor

@wwcchh0123 wwcchh0123 commented Sep 9, 2024

reslove #341

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 1a78d5f
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66dff12ef856e7000801b6c1

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 36.49%. Comparing base (9679b3c) to head (1a78d5f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/storage/s3.go 0.00% 35 Missing ⚠️
main.go 0.00% 3 Missing ⚠️
internal/linters/github.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   37.05%   36.49%   -0.57%     
==========================================
  Files          27       27              
  Lines        2194     2228      +34     
==========================================
  Hits          813      813              
- Misses       1265     1299      +34     
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi merged commit ecbc001 into qiniu:master Sep 10, 2024
7 checks passed
CarlJi pushed a commit to CarlJi/reviewbot that referenced this pull request Sep 19, 2024
* feat: Log storage adapted to s3

* v2
wwcchh0123 added a commit to wwcchh0123/reviewbot that referenced this pull request Nov 13, 2024
* feat: Log storage adapted to s3

* v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants