Skip to content

fix: use runner to run go mod tidy #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix: use runner to run go mod tidy #290

merged 3 commits into from
Aug 29, 2024

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Aug 28, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit b6b2d54
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/66d059978bbb6b0008a9b037

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.09091% with 56 lines in your changes missing coverage. Please review.

Project coverage is 37.12%. Comparing base (f4e697d) to head (b6b2d54).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/runner/docker.go 67.79% 12 Missing and 7 partials ⚠️
internal/linters/go/golangci_lint/golangci_lint.go 0.00% 16 Missing ⚠️
config/config.go 17.64% 14 Missing ⚠️
internal/runner/runner.go 64.70% 4 Missing and 2 partials ⚠️
server.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   35.01%   37.12%   +2.11%     
==========================================
  Files          23       23              
  Lines        1705     1783      +78     
==========================================
+ Hits          597      662      +65     
+ Misses       1041     1040       -1     
- Partials       67       81      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi force-pushed the proposal/custom_runner branch 3 times, most recently from 49d877a to c6988d2 Compare August 29, 2024 10:02
@CarlJi CarlJi force-pushed the proposal/custom_runner branch from c6988d2 to 9918737 Compare August 29, 2024 10:06
@CarlJi CarlJi force-pushed the proposal/custom_runner branch from 293ec1e to b6b2d54 Compare August 29, 2024 11:20
@CarlJi CarlJi merged commit 3269168 into qiniu:master Aug 29, 2024
8 of 9 checks passed
@CarlJi CarlJi deleted the proposal/custom_runner branch August 29, 2024 11:26
wwcchh0123 pushed a commit to wwcchh0123/reviewbot that referenced this pull request Nov 13, 2024
@CarlJi @wwcchh0123
fix: use runner to run go mod tidy (qiniu#290)
a121113 
* fix: use runner to run go mod tidy

* feat: provide modifier interface for config

* test: add cases for runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CarlJi