Skip to content

Conversation

wwcchh0123
Copy link
Contributor

@wwcchh0123 wwcchh0123 commented Jul 17, 2024

fix #245

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 4bfc8ad
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/669e08e7c9a5dc0008ab0676

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (515b073) to head (4bfc8ad).
Report is 2 commits behind head on master.

Files Patch % Lines
internal/linters/go/golangci_lint/golangci_lint.go 50.00% 20 Missing and 1 partial ⚠️
internal/linters/linters.go 0.00% 2 Missing ⚠️
internal/linters/c/cppcheck/cppcheck.go 0.00% 1 Missing ⚠️
internal/linters/go/staticcheck/staticcheck.go 0.00% 1 Missing ⚠️
internal/linters/lua/luacheck/luacheck.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   37.95%   36.82%   -1.13%     
==========================================
  Files          19       19              
  Lines        1386     1404      +18     
==========================================
- Hits          526      517       -9     
- Misses        818      846      +28     
+ Partials       42       41       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wwcchh0123 wwcchh0123 force-pushed the ehance0715 branch 3 times, most recently from c212b46 to ce478dd Compare July 18, 2024 10:53
@wwcchh0123 wwcchh0123 force-pushed the ehance0715 branch 2 times, most recently from 9d83d5a to d993854 Compare July 22, 2024 03:30
@CarlJi CarlJi merged commit 18103a8 into qiniu:master Jul 22, 2024
7 of 9 checks passed
never112 pushed a commit to never112/reviewbot that referenced this pull request Jul 30, 2024
* improve golangci-lint default execution path

* adjust logic

* add ut

* adjust findgomods
wwcchh0123 added a commit to wwcchh0123/reviewbot that referenced this pull request Nov 13, 2024
* improve golangci-lint default execution path

* adjust logic

* add ut

* adjust findgomods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint(gomod): enhance the ability for go.mod finding
2 participants