Add BM25 options to inference config #6893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8c4b13 to
345c165
Compare
coszio
reviewed
Jul 22, 2025
| @@ -7,6 +7,36 @@ inference: | |||
| address: "http://localhost:2114/api/v1/infer" | |||
| timeout: 10 | |||
| token: "98eb568c-dea5-4347-a3a5-583478983bb9" | |||
| # Define custom models/vectorizer, which get handled directly in Qdrant. These do not require an `address` to be configured. | |||
There was a problem hiding this comment.
Maybe they can, but it is up to the specific model params. In the case of BM25 it is not needed bc it is computed in qdrant directly.
There was a problem hiding this comment.
What do you mean? custom_models is supposed to only handle 'models' that are handled directly in Qdrant, like BM25.
There was a problem hiding this comment.
I was thinking that maybe in the future users might be able to plug in their own embedding services via a custom config like this. In this case another default namespace might be more fitting like bm25/bm25-for-paragraphs, or native/bm25
generall
requested changes
Jul 23, 2025
|
Closing in favor of #6939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6891
Adds configuration for BM25 vectorizer "models" in inference. One example model with the name
bm25added in development config too.Highlights: