Skip to content

Conversation

jayantpranjal0
Copy link
Contributor

@jayantpranjal0 jayantpranjal0 commented Jun 17, 2025

Closes: #3370

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This comment was marked as resolved.

@jayantpranjal0
Copy link
Contributor Author

@timvisee can you check out this pr?

@@ -110,7 +110,7 @@ struct Args {
/// Format: <config_file_path>
///
/// Default path: config/config.yaml
#[arg(long, value_name = "PATH")]
#[arg(long, value_name = "PATH", env = "QDRANT_CONFIG_PATH")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we set the correct absolute path as default anywhere here?

I don't think we do. In which case Qdrant will not use the above config when installed by default, and it will not use the configured absolute paths.

Copy link
Contributor Author

@jayantpranjal0 jayantpranjal0 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we set the default value in default config value settings.rs file. In linux after default installation user would have to set up the environment variable to use any other files, which in the debian package is already copied to etc/qdrant/config.yaml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timvisee can you let me know if you think anything should be changed. From what I have understood just setting an environment variables by using export in shell environment would do the work. There just adding an environment variables here does the job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timvisee can you please let me know your thoughts

Copy link
Member

@timvisee timvisee Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In linux after default installation user would have to set up the environment variable to use any other files, which in the debian package is already copied to etc/qdrant/config.yaml.

I don't think this is the right approach. It would require additional configuration by the user, but we want to change default behavior here.

If we ship some default configuration and put it on disk, which we do. Qdrant should use the configuration at that path by default.

If we don't do that, the absolute paths this PR sets will not be used in deployments by default.

We should therefore make Qdrant look for the configuration at /etc/qdrant/config.yaml by default, but only when packaged for Debian.

@timvisee
Copy link
Member

Thanks for working on this!

Superseded by #6958

@timvisee timvisee closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants