Add dock button to keep description pane open #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks good. Two very minor things:
static boolean showDescriptionEditor(ProjectImageEntry<?> entry) {
TextArea editor = new TextArea();
editor.setWrapText(true);
editor.setPromptText("Enter description for " + entry.getImageName());
editor.setText(entry.getDescription());
Dialog<ButtonType> dialog = new Dialog<>();
dialog.getDialogPane().getButtonTypes().setAll(ButtonType.OK, ButtonType.CANCEL);
dialog.setTitle("Image description");
dialog.getDialogPane().setHeaderText(entry.getImageName());
dialog.getDialogPane().setContent(editor);
Platform.runLater(editor::requestFocus);
Optional<ButtonType> result = dialog.showAndWait();
if (result.isPresent() && result.get() == ButtonType.OK && editor.getText() != null) {
var text = editor.getText();
entry.setDescription(text.isEmpty() ? null : text);
return true;
}
return false;
}I suggest and/or because receiving the focus means the prompt text isn't visible anyway... so I don't have a strong opinion on which is preferable. |
|
Both comments were addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing this issue.
It is done by adding a button to keep the description pane of an image entry open:
If this button is on, then the description pane will stay visible, even if the selected image entry doesn't have any description.
A preference was added to save the button status when QuPath restarts.
An edit button was also added to easily edit the description. It is only shown when an image is currently selected.
The caret in the description pane is not visible anymore.