Skip to content

Implement spinners for Z and T selection in viewer #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Implement spinners for Z and T selection in viewer #1799

wants to merge 15 commits into from

Conversation

alanocallaghan
Copy link
Contributor

@alanocallaghan alanocallaghan commented Mar 13, 2025 •
edited
Loading

After discussion in #1797, implement spinners instead of sliders. Can't enter text as that's bound to channel toggling.

Screenshot from 2025-03-13 15-03-28

@alanocallaghan
Copy link
Contributor Author

I realise I did a bit of cargo cult programming and offset the T spinner for no good reason

@alanocallaghan
Copy link
Contributor Author

Less bad image

@alanocallaghan alanocallaghan changed the title Implement spinners for Z and T selection in viewer, caveat: can't enter text Implement spinners for Z and T selection in viewer Mar 13, 2025
@petebankhead petebankhead marked this pull request as ready for review March 13, 2025 19:59
@petebankhead
Copy link
Member

Ready for review, I think...

  • Uses a translucent black background to make more visible in both dark and light mode
  • Supports typing the input, clicking the spinner buttons or clicking/dragging on the slider (really a progress bar)
new-z-t-sliders

@alanocallaghan
Copy link
Contributor Author

Seems like a massive improvement, being

  • more visible
  • more explicit (showing what each slider does, current value and range)
  • easier to use
  • more accessible (better contrast)
  • generally prettier (subjectively)

@petebankhead petebankhead mentioned this pull request Mar 14, 2025
Merged
@alanocallaghan alanocallaghan deleted the z-t-spinners branch June 3, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanocallaghan @petebankhead @finglis