Skip to content

Added a confirmation message box before forgetting a room #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

Added a confirmation message box before forgetting a room #907

merged 2 commits into from
Feb 10, 2025

Conversation

dymoksc
Copy link
Contributor

@dymoksc dymoksc commented Oct 13, 2024

Fixes #236

KitsuneRal
KitsuneRal approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the contribution! Looks good, aside from a couple of suboptimal places - I will fix them myself shortly.

@KitsuneRal KitsuneRal merged commit 6732057 into quotient-im:dev Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forgetting should be confirmed by the user
2 participants
@dymoksc @KitsuneRal