Chatedit: make default paste mode configurable #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149d71f to
b778d85
Compare
Many people like pasting plain text as there is less trouble with it and does the job. Even Element pastes plain text by default despite being a rich client. This is why this patch switches to plain text pasting by default while makes it configurable. Other version can be pasted by `Ctrl+Shift+V`. Cc quotient-im#849
b778d85 to
be3909d
Compare
|
While this looks like as a usable workaround, I still feel like the current paste-as-HTML impl is fundamentally broken in its implementation. If it can't reliably paste in HTML that has been selected in the browser window, it does not look fit for purpose as is. Pasting 100% complete well formed HTML documents does not look likely to be the common case. |
KitsuneRal
requested changes
Feb 27, 2023
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
KitsuneRal
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people like pasting plain text as there is less trouble with
it and does the job. Even Element pastes plain text by default
despite being a rich client. This is why this patch switches to
plain text pasting by default while makes it configurable.
Other version can be pasted by
Ctrl+Shift+V.Cc #849