Use default RUNNER_MANUALLY_TRAP_SIG
#634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💡 If you need a new version, create a new release after merge. |
RUNNER_MANUALLY_TRAP_SIG
RUNNER_MANUALLY_TRAP_SIGRUNNER_MANUALLY_TRAP_SIG
int128
commented
Feb 5, 2025
| @@ -42,14 +42,11 @@ COPY entrypoint.sh / | |||
|
|
|||
| VOLUME /var/lib/docker | |||
|
|
|||
| # docker-init sends the signal to children | |||
| ENV RUNNER_MANUALLY_TRAP_SIG= | |||
There was a problem hiding this comment.
By default, RUNNER_MANUALLY_TRAP_SIG is set to 1.
https://github.com/actions/runner/blob/3486c54ccbb8181b3bb46e1a3f22c85f79aa5414/images/Dockerfile#L38
If RUNNER_MANUALLY_TRAP_SIG is set, run.sh waits for the listener when a signal is received.
https://github.com/actions/runner/blob/3486c54ccbb8181b3bb46e1a3f22c85f79aa5414/src/Misc/layoutroot/run.sh#L29
|
💡 If you need a new version, create a new release after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
Currently, the job is stuck for about 20 minutes when the pod is accidentally terminated. It finally causes the job timeout or "lost communication" error.
This changes
RUNNER_MANUALLY_TRAP_SIGenvironment variable to the default value of upstream image. By this change, the job will be canceled shortly on pod termination.Issue