Do not use a default value in EYE #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colescott
previously approved these changes
Nov 4, 2020
2464ca0 to
91ebefb
Compare
notmgsk
approved these changes
Nov 4, 2020
|
Original commit was the wrong thing, since |
colescott
reviewed
Nov 4, 2020
There was a problem hiding this comment.
It might be good to remove the other defaults in this file that are just copies of the magicl defaults to avoid confusion like this in the future. (L34,40,46)
I think the original purpose for leaving those in is to allow the caller to see what the default will be, however this might not be worth the added weirdness.
stylewarning
approved these changes
Nov 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EYEwrapsMAGICL:EYE, which may be provided with both a type and a value for the diagonal. Currently,MAGICL:EYEwillCOERCEthe value to the type, if need be. However,(complex double-float)cannot be coerced todouble-float, even if the imaginary part is zero. Every so often quilc tries to construct a double-float identity matrix, e.g. here https://github.com/rigetti/quilc/blob/master/src/compilers/approx.lisp#L201, and this will cause an error.