Skip to content

Conversation

chenrui333
Copy link

seeing some time related failure

error[E0282]: type annotations needed for `Box<_>`
  --> /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

has been addressed with 0.3.36, time-rs/time#693

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title chore: update to use rust 1.80 chore: update to build with rust 1.80 Aug 1, 2024
@quietvoid
Copy link
Owner

quietvoid commented Aug 2, 2024

It builds fine here.
Am I missing something? The current lockfile is already on time version = "0.3.36".

The PR doesn't seem necessary. Plus for some reason your changes break the tests.

@quietvoid quietvoid closed this Aug 2, 2024
@chenrui333
Copy link
Author

@quietvoid yeah, you are right, it got handled with 03e41c4. (I might be looking at something else)

While we are in here, any chance cutting a new release? Thanks!

@chenrui333 chenrui333 deleted the rust-1.80 branch August 2, 2024 15:15
@quietvoid
Copy link
Owner

Yeah I can make a new release this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants