Skip to content

util: Add opentelemetry support (PROJQUAY-8902) #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 7, 2025
Merged

util: Add opentelemetry support (PROJQUAY-8902) #3863

merged 12 commits into from
May 7, 2025

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented May 6, 2025

No description provided.

@kleesc kleesc requested a review from Marcusk19 May 6, 2025 13:42
@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch from 5fe1563 to c42e122 Compare May 6, 2025 13:48
@kleesc kleesc requested a review from bcaton85 May 6, 2025 13:48
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.86957% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (8332d99) to head (7d79de8).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
util/metrics/otel.py 55.26% 16 Missing and 1 partial ⚠️
app.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   70.60%   70.58%   -0.02%     
==========================================
  Files         443      444       +1     
  Lines       42187    42231      +44     
  Branches     4807     4809       +2     
==========================================
+ Hits        29785    29810      +25     
- Misses      10711    10727      +16     
- Partials     1691     1694       +3
Flag Coverage Δ
unit 70.58% <60.86%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Marcusk19
Marcusk19 previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@Marcusk19 Marcusk19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch 2 times, most recently from 48ac7f1 to 649624e Compare May 6, 2025 19:56
@kleesc kleesc changed the title Otel trace manifest endpoint only util: Add opentelemetry support (PROJQUAY-0000) May 6, 2025
@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch 2 times, most recently from e651df2 to 4ad739e Compare May 7, 2025 13:50
@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch 2 times, most recently from dfb5757 to edb2632 Compare May 7, 2025 17:36
@kleesc kleesc changed the title util: Add opentelemetry support (PROJQUAY-0000) util: Add opentelemetry support (PROJQUAY-8902) May 7, 2025
@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch 4 times, most recently from d5f8e7d to 95b47bb Compare May 7, 2025 19:09
@kleesc kleesc force-pushed the otel-trace-manifest-endpoint-only branch from 95b47bb to 7d79de8 Compare May 7, 2025 19:11
@kleesc kleesc enabled auto-merge (squash) May 7, 2025 19:50
@kleesc kleesc merged commit e838a58 into quay:master May 7, 2025
17 of 18 checks passed
@kleesc kleesc deleted the otel-trace-manifest-endpoint-only branch May 7, 2025 19:59
bcaton85 added a commit to bcaton85/quay that referenced this pull request Jun 4, 2025
@bcaton85
Revert "util: Add opentelemetry support (PROJQUAY-8902) (quay#3863)"
2083401 
This reverts commit e838a58.
bcaton85 added a commit that referenced this pull request Jun 4, 2025
@bcaton85
Revert "util: Add opentelemetry support (PROJQUAY-8902) (#3863)" (#3999)
405d34f 
This reverts commit e838a58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcusk19 Marcusk19 Marcusk19 approved these changes

@bcaton85 bcaton85 Awaiting requested review from bcaton85

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleesc @Marcusk19