Skip to content

build: move quay to python 3.12 (PROJQUAY-8800) #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 29, 2025
Merged

build: move quay to python 3.12 (PROJQUAY-8800) #3780

merged 21 commits into from
May 29, 2025

Conversation

syed
Copy link
Contributor

@syed syed commented Apr 14, 2025 •
edited
Loading

Needed to support MCP

Summary (AI generated)

This PR upgrades the project from Python 3.9 to Python 3.12 and introduces several pipeline, Docker, and dependency updates. Below are the key changes and areas for consideration:

Key Changes

  1. Python Upgrade

    • Updated CI workflows to use actions/setup-python@v4 with Python 3.12.
    • Removed custom OpenSSL 1.1 setup for Python 3.9 and replaced it with actions/setup-python.
    • Updated Dockerfile to use UBI9 with Python 3.12 as the base image.

  2. Dependency Updates

    • Replaced rehash with resumablesha256.
    • Removed deprecated libraries like bencode and deprecated.
    • Adjusted mypy.ini to handle new dependencies.

  3. Pipeline Simplification

    • Removed redundant and manual steps for Python installation in CI workflows.
    • Updated tox environments and test configurations to align with Python 3.12.

  4. Dockerfile Enhancements

    • Switched to UBI9 base image for better compatibility.
    • Improved permission handling for directories such as /etc/pki/ and /etc/ssl/.
    • Added dumb-init for enhanced process management.

  5. Test Suite Adjustments

    • Updated test configurations and tox commands to reflect the Python 3.12 upgrade.

  6. Configuration Updates

    • Updated Makefile for black to use Python 3.12 target.
    • Tweaked initialization scripts to resolve UBI9-specific permission issues.

@syed syed force-pushed the mcp branch 4 times, most recently from 65de76d to d898590 Compare April 16, 2025 19:07
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (556545b) to head (cb8c4ec).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3780      +/-   ##
==========================================
- Coverage   70.59%   70.50%   -0.09%     
==========================================
  Files         444      444              
  Lines       42232    42334     +102     
  Branches     4809     4809              
==========================================
+ Hits        29812    29847      +35     
- Misses      10727    10796      +69     
+ Partials     1693     1691       -2
Flag Coverage Δ
unit 70.50% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bcaton85 bcaton85 merged commit 723102e into quay:master May 29, 2025
18 checks passed
@syed syed mentioned this pull request Aug 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcaton85 bcaton85 bcaton85 approved these changes

@deshpandevlab deshpandevlab deshpandevlab approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syed @bcaton85 @deshpandevlab