-
Notifications
You must be signed in to change notification settings - Fork 3k
[3.28] Fail the build if runtime Config objects are used during deployment time #48973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[3.28] Fail the build if runtime Config objects are used during deployment time #48973
Conversation
This comment has been minimized.
This comment has been minimized.
@radcortez I can live with the quickstarts being broken for some time but the failures in the Core ITs look suspicious. |
Yes, I've missed the The |
0226d2f
to
18471da
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will have to wait for the warning to be in a LTS version before we make it an error.
So basically, we need to merge it once 3.26 has been branched.
We should fix the Ecosystem anyway so it's a good thing we have this PR.
Sure. |
I had a message to not merge anyway in the description. The goal was to check the ecosystem behaviour. Unfortunately, unless we manually validate, we will only get the entire picture when we merge. Would you happen to have any idea? |
Yeah, for now unfortunately, we don't have a lot of options. You can test the Platform by adding the |
Hi @radcortez I think that updating |
Yes, we missed that one. Done here: #49293 |
18471da
to
e44cab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and we can merge this once CI is green as we branched 3.26 already.
This comment has been minimized.
This comment has been minimized.
@radcortez I think there's probably a remaining issue with |
e44cab5
to
5bd1c3a
Compare
It's missing the dependency update. Just pushed it. |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
❌ | Quickstarts Compilation - JDK 17 | Compile Quickstarts |
Failures | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ Quickstarts Compilation - JDK 17 #
- Failing: jms-quickstart
📦 jms-quickstart
❌ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project jms-quickstart: Failed to build quarkus application
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/smallrye-reactive-messaging/deployment
❌ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector
- History
Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"]
-java.lang.AssertionError
java.lang.AssertionError:
Expecting actual:
["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
["-3", "-4", "-5", "-6"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)
⚙️ Gradle Tests - JDK 17
📦 integration-tests/gradle
❌ io.quarkus.gradle.BuildConfigurationTest.buildNoOverride
- History
Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path:
-org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError:
Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar']
Expecting path:
/home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/quarkus-app/quarkus-run.jar
to exist (symbolic links were followed).
⚙️ Gradle Tests - JDK 17 Windows
📦 integration-tests/gradle
❌ io.quarkus.gradle.BuildConfigurationTest.buildNoOverride
- History
Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path:
-org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError:
Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar']
Expecting path:
D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
In 3.25 we added a warning if extensions use runtime config objects during deployment time: #48500
This changes the warning to fail instead.
Do not Merge - This is to give us a view on how the ecosystem behaves so we can fix the issues: