Skip to content

Conversation

@radcortez radcortez added release/breaking-change area/config triage/on-ice Frozen until external concerns are resolved labels Jul 17, 2025

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jul 22, 2025

@radcortez I can live with the quickstarts being broken for some time but the failures in the Core ITs look suspicious.

@radcortez
Copy link
Member Author

Yes, I've missed the DB2PoolRecorder in the original PR.

The jms-virtual-threads is trickier because we depend on the Quakiverse Extension. I've already sent a PR here: quarkiverse/quarkus-artemis#864

@radcortez radcortez force-pushed the fail-runtime-config-at-deployment branch from 0226d2f to 18471da Compare July 22, 2025 10:55

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will have to wait for the warning to be in a LTS version before we make it an error.

So basically, we need to merge it once 3.26 has been branched.

We should fix the Ecosystem anyway so it's a good thing we have this PR.

@gsmet gsmet changed the title Fail the build if runtime Config objects are used during deployment time [3.28] Fail the build if runtime Config objects are used during deployment time Jul 23, 2025
@radcortez
Copy link
Member Author

Sure.

@radcortez
Copy link
Member Author

I had a message to not merge anyway in the description. The goal was to check the ecosystem behaviour.

Unfortunately, unless we manually validate, we will only get the entire picture when we merge. Would you happen to have any idea?

@gsmet
Copy link
Member

gsmet commented Jul 23, 2025

Yeah, for now unfortunately, we don't have a lot of options.

You can test the Platform by adding the ci/test-platform label and rebasing. But that's all we have for now.

@jedla97
Copy link
Contributor

jedla97 commented Jul 30, 2025

Hi @radcortez I think that updating quarkus-reactive-db2-client before LTS would be nice, and maybe not that scary for users as they would see new warning. WDYT?

@radcortez
Copy link
Member Author

Yes, we missed that one. Done here: #49293

@gsmet gsmet force-pushed the fail-runtime-config-at-deployment branch from 18471da to e44cab5 Compare August 19, 2025 15:49
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and we can merge this once CI is green as we branched 3.26 already.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 19, 2025

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 20, 2025

@radcortez I think there's probably a remaining issue with quarkus-artemis?

@radcortez radcortez force-pushed the fail-runtime-config-at-deployment branch from e44cab5 to 5bd1c3a Compare August 20, 2025 09:28
@radcortez
Copy link
Member Author

It's missing the dependency update. Just pushed it.

Copy link

quarkus-bot bot commented Aug 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5bd1c3a.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs 🚧

You can consult the Develocity build scans.

Failures

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: jms-quickstart 

📦 jms-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project jms-quickstart: Failed to build quarkus application


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  /home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/quarkus-app/quarkus-run.jar
to exist (symbolic links were followed).

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).

Copy link

quarkus-bot bot commented Sep 2, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that the injected config class has to be the entry point of the @ConfigMapping
4 participants