Skip to content

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented May 29, 2025

Also fix some missed propagations.

@Ladicek
Copy link
Contributor

Ladicek commented May 30, 2025

There's nothing wrong with this, so I approved, but this demonstrates once again why I dislike the GenericType more and more: to be practically useful, it needs to spread throughout the codebase, even though the primary usecase (generating signatures) is something very few users actually care about. They would get that for free if they used GenericType, but constructing it is actually fairly hard, so I predict very few people will actually care, since it's totally optional. Oh well.

@Ladicek
Copy link
Contributor

Ladicek commented May 30, 2025

Actually one thing: we should probably validate that the erasure of the given generic type is equal to the ClassDesc of the field descriptor / method return type / etc.

@dmlloyd dmlloyd merged commit 085bb56 into quarkusio:main Jun 2, 2025
1 check passed
@dmlloyd dmlloyd deleted the generics-again branch June 2, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants