avoid classloader leak seemingly caused by Util.findSam()
#477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Util.findSam()` method uses `ClassValue` to cache its result, which for some reason I do not claim to understand seems to cause a classloader leak. It feels likely the cause is more subtle, or entirely different, but avoiding `ClassValue` caching seems to get rid of the leak, or at least of its symptoms, so after spending two days staring into heap dumps and figuring out nothing, I'm just removing it and leaving it for someone else :-)
|
It's because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Util.findSam()method usesClassValueto cache its result, which for some reason I do not claim to understand seems to cause a classloader leak. It feels likely the cause is more subtle, or entirely different, but avoidingClassValuecaching seems to get rid of the leak, or at least of its symptoms, so after spending two days staring into heap dumps and figuring out nothing, I'm just removing it and leaving it for someone else :-)