add automated testing of documentation examples #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of flags is more than 8, so `byte` is _not_ big enough. It is also less than 16, so `short` is big enough. This commit also improves the error messages related to adding/removing flags and access levels.
a580e87 to
3c7104c
Compare
|
This is extremely cool! |
|
The possibility occurred to me when David started (in later chapters) generating classes with the classic |
3c7104c to
e1a93a8
Compare
|
Yeah, in Hibernate Validator, we use proper classes for examples and we include the code in the doc. It's nice because you can have more test infrastructure around. But it's not ideal as you don't have the source handy when you edit the doc files. The approach you took is perfect for Gizmo's case. |
This commit also fixes several bugs found in the examples.
e1a93a8 to
6b44c21
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.