Jandex integration #445
Closed
Jandex integration #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the anticipation of adding a 2nd module, Jandex integration, this commit turns Gizmo 2 into a multimodule Maven project. The main code is now part of the `core` module, which retains the previous Maven coordinates as well as the JPMS module name. The top-level project is a Maven `pom` module which contains no code.
The `jandex` module is added which hosts the Jandex integration. It depends on the `core` module (both in the Maven sense and in the JPMS sense) and of course on Jandex. The `Jandex2Gizmo` class contains `static` methods to create `ClassDesc` (and other descriptors) from Jandex types (such as `DotName`, `Type` or `ClassInfo`). More methods will be coming in the future (notably, to create `GenericType` from `Type` and to create annotation from `AnnotationInstance`).
f109c5f to
e663b4b
Compare
|
I don't like making this whole project a multi-module project for one class. Could Jandex not have one extra class and one optional dependency? Or, was there a problem with adding an optional dependency to Jandex that I'm not remembering? |
|
I didn't even think of putting the Gizmo 2 integration into Jandex, but we can do that, sure. No problem with that. |
|
BTW, you also wanted to maybe have a Gizmo "runtime", which would have to be another module in here I think? |
|
Yeah that's possible for the future. |
|
Well, OK then. I'll move this to Jandex (not to the core, I'll make a new module there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301