Skip to content

Conversation

gastaldi
Copy link
Contributor

No description provided.

@gastaldi gastaldi requested a review from dmlloyd April 10, 2025 16:40
@gsmet
Copy link
Member

gsmet commented Apr 10, 2025

@dmlloyd note that this PR will change the version in main to 2.999-SNAPSHOT - mostly because otherwise updating the next version will be a pain. It could also be changed to 999-SNAPSHOT if you prefer - it won't conflict with Gizmo 1 even if we push this infra to Gizmo 1 too given they have different GAs.

Let us know what you think.

@dmlloyd
Copy link
Member

dmlloyd commented Apr 10, 2025

It isn't that painful to use the next stable version (in this case 2.0.0-SNAPSHOT), we've done this plenty of times in the past. What problem is being solved here?

@gastaldi
Copy link
Contributor Author

I'm fine with either, I guess @gsmet concerns' is because once 2.1.x is released you need to change that too, whereas if you use 2.999-SNAPSHOT you don't ever touch that variable

@gsmet
Copy link
Member

gsmet commented Apr 10, 2025

Exactly that ^

But the idea is that you could trigger the releases yourself from now on so we can do whatever you prefer :)

@gastaldi
Copy link
Contributor Author

I reverted to 2.0.0-SNAPSHOT for now, we can discuss about the 999 idea in a later stage

@gastaldi gastaldi merged commit da18bd0 into main Apr 10, 2025
10 checks passed
@gastaldi gastaldi deleted the gastaldi-patch-1 branch April 10, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants