check arguments count and types when invoking methods #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We first check that the number of passed arguments is equal to the number of declared parameters. Then, we check that `TypeKind.asLoadable()` of all arguments are equal to the loadable `TypeKind` of the corresponding parameters. This is technically relatively lax and only properly checks primitive types, but we don't have a type system to find out if references of different types (such as `String` and `CharSequence`) are assignable. Therefore, this is the best we can do (at least for now).
dmlloyd
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first check that the number of passed arguments is equal to the number of declared parameters. Then, we check that
TypeKind.asLoadable()of all arguments are equal to the loadableTypeKindof the corresponding parameters. This is technically relatively lax and only properly checks primitive types, but we don't have a type system to find out if references of different types (such asStringandCharSequence) are assignable. Therefore, this is the best we can do (at least for now).Fixes #309