Skip to content

Remove unused default method #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Remove unused default method #392

merged 1 commit into from
May 22, 2025

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented May 21, 2025 •
edited
Loading

It's overridden in both subclasses. Also, the doc is not strictly accurate because a field deref might get bound.

@dmlloyd dmlloyd added the 2.x Issue applies to Gizmo 2.x label May 21, 2025
@Ladicek
Copy link
Contributor

Ladicek commented May 22, 2025

I think I'd actually like to remove the bound() method from public API completely. I don't see a purpose it would serve for users.

@Ladicek Ladicek merged commit f22ad97 into quarkusio:main May 22, 2025
1 check passed
@Ladicek Ladicek moved this to Done in WG - Gizmo 2 May 22, 2025
@Ladicek Ladicek mentioned this pull request May 22, 2025
Merged
@dmlloyd dmlloyd deleted the unused-bound branch May 22, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
2.x Issue applies to Gizmo 2.x
Projects
WG - Gizmo 2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmlloyd @Ladicek