Create flags and access levels abstraction #384

dmlloyd · 2025-05-15T20:18:27Z

Fixes #335.

Version 1 of this change used type-safe constants for all of the modifiers and access levels; it was pretty nifty but added about 30-40 new types, so it seemed a bit to heavy to justify.

This version makes a fair effort to put convenience methods in the right place, but otherwise does all checking at run time.

At present, if you try to introduce a flag to a creator which always forces that flag to be set, then you will get an exception. I'm undecided whether this is a preferable behavior.

I did not do anything about default access levels or modifiers yet, other than more or less mirroring what was already in the code.

src/main/java/io/quarkus/gizmo2/creator/ModifiableCreator.java

src/main/java/io/quarkus/gizmo2/impl/AbstractMethodCreatorImpl.java

src/main/java/io/quarkus/gizmo2/impl/AnonymousClassCreatorImpl.java

Ladicek · 2025-05-19T08:05:49Z

Mostly LGTM, just a few small corrections and questions.

src/main/java/io/quarkus/gizmo2/creator/Access.java

src/main/java/io/quarkus/gizmo2/creator/ModifierFlag.java

src/main/java/io/quarkus/gizmo2/creator/ModifiableCreator.java

Fixes quarkusio#335. Version 1 of this change used type-safe constants for all of the modifiers and access levels; it was pretty nifty but added about 30-40 new types, so it seemed a bit to heavy to justify. This version makes a fair effort to put convenience methods in the right place, but otherwise does all checking at run time. At present, if you try to introduce a flag to a creator which always forces that flag to be set, then you will get an exception. I'm undecided whether this is a preferable behavior. I did not do anything about default access levels or modifiers yet, other than more or less mirroring what was already in the code.

…, so that we do not have the `NONE` location anymore

dmlloyd added the 2.x Issue applies to Gizmo 2.x label May 15, 2025