Introduce revoke node operation #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a value is being popped, and the creation of the value involves void-typed operations whose only side effect is to mutate or set up that value, then we can revoke the void-typed nodes and pop their dependencies. In some cases the entire operation can be erased, if the mutation operation values do not have any side effects. Also fixed a bug in `Dup#pop` where the node returned can be null due to excising the node from the list before capturing its `prev` pointer.
Ladicek
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a value is being popped, and the creation of the value involves void-typed operations whose only side effect is to mutate or set up that value, then we can revoke the void-typed nodes and pop their dependencies. In some cases the entire operation can be erased, if the mutation operation values do not have any side effects.
Also fixed a bug in
Dup#popwhere the node returned can be null due to excising the node from the list before capturing itsprevpointer.