improvements #366
Merged
improvements #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is often required to create a method descriptor for a dynamically created class, but the method name and type are statically known. The new overloads are easier to use in that case.
If the user attempts to emit `invokeinterface`, they must pass an `InterfaceMethodDesc`. If they don't, we now throw an exception with an explanation.
… fallthrough If an `ExecutableCreator` body falls through, the exception message contains (when tracking is enabled) the creation site of the corresponging creator.
If a `LocalVar` was not allocated, the exception message contains (when tracking is enabled) its creation site, and it always contains the name of the variable and a hint to check the declaring `BlockCreator`. Further, this commit adds missing `checkSlot()` call to a few places.
dmlloyd
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Class,Interface}MethodDescLocalVarwas not allocated