fix static field with an initializer #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a `static` field was provided with an initializer (that is, either a block of code or a constant that cannot be represented in the constant pool), the code of that initializer was never emitted. This commit fixes that.
|
Marking this as a draft because only the first added test passes. The second one doesn't, and I don't really see a way to fix that -- it seems it's a bug right in the dependency tracking thing I don't really understand :-) I'd appreciate if you @dmlloyd could take a look when you find the time. |
|
It was a subtle block inlining problem. Blocks get inlined sometimes to help |
dmlloyd
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a
staticfield was provided with an initializer (that is, either a block of code or a constant that cannot be represented in the constant pool), the code of that initializer was never emitted. This commit fixes that.