Repeat annotation validation #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
commented
Apr 15, 2025
| } | ||
| } | ||
|
|
||
| void addInvisible(Consumer<? super RuntimeInvisibleAnnotationsAttribute> consumer) { | ||
| if (!invisible.isEmpty()) { | ||
| consumer.accept(RuntimeInvisibleAnnotationsAttribute.of(visible)); |
There was a problem hiding this comment.
Found a little bug here.
Ladicek
reviewed
Apr 15, 2025
| * If the annotation is {@linkplain Repeatable repeatable}, and adding this annotation would | ||
| * cause there to be more than one instance of the given annotation on this element, | ||
| * then the existing annotation and the given annotation are automatically wrapped in the | ||
| * repeatable annotation wrapper. |
There was a problem hiding this comment.
Suggested change
| * repeatable annotation wrapper. | |
| * container annotation. |
it I believe the proper wording.
Ladicek
approved these changes
Apr 15, 2025
Also, support for `@Repeatable`. Fixes quarkusio#341
|
Sure enough, the test found a bug. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, support for
@Repeatable. Fixes #341