Non capturing lambdas should be singleton #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing tests already cover capturing and non-capturing cases. Also fixes a bug where a relational- or compare-to-zero-if statement at the end of a block is still considered to possibly fall through even if none of its branches fall through. Fixes quarkusio#266
Ladicek
approved these changes
Apr 8, 2025
|
It's about the lambda instance - the object which implements the functional interface. If there are captures, we must construct a new instance each time with the captured values. If not, we can return the same instance each time. |
|
Ah, yes, makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing tests already cover capturing and non-capturing cases. Also fixes a bug where a relational- or compare-to-zero-if statement at the end of a block is still considered to possibly fall through even if none of its branches fall through.
Fixes #266