Implement instance field initializers #297
Conversation
src/main/java/io/quarkus/gizmo2/impl/InstanceFieldCreatorImpl.java
Outdated
Show resolved
Hide resolved
| ifc.withType(String.class); | ||
| ifc.final_(); | ||
| ifc.withInitializer(b0 -> { | ||
| b0.yield(b0.withString(Constant.of("Hello")).concat(Constant.of(" world"))); |
There was a problem hiding this comment.
The yield() call here is not entirely intuitive, but I'm not sure what we can do about that. Maybe make withInitializer() take Function<BlockCreator, Expr> instead of Consumer<BlockCreator>?
There was a problem hiding this comment.
This is not specific to this case... any block which has an output type (including switch expressions, ?:, etc.) works this way. I agree it's not super intuitive and it can be easy to mess it up, but I don't see a good way of changing it in a uniform way without breaking a lot of things (or else changing all Consumer to Function and requiring users to return a void constant or something).
There was a problem hiding this comment.
We can have a separate discussion on that, at any rate.
| * | ||
| * @param initial the initial value | ||
| */ | ||
| default void withInitial(Class<?> initial) { |
There was a problem hiding this comment.
Hm, do you expect many Class<?> fields? 😉
Fixes #250