Skip to content

Do not allow builders to accept raw Expr #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Do not allow builders to accept raw Expr #288

merged 1 commit into from
Apr 7, 2025

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Apr 7, 2025

Fixes #248

@dmlloyd dmlloyd added the 2.x Issue applies to Gizmo 2.x label Apr 7, 2025
Ladicek
Ladicek approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why ? super LocalVar, but then figured it's a LocalVar that is passed to all the affected BiConsumers and it's probably a good idea to highlight that it's freely reusable. LGTM

@dmlloyd dmlloyd merged commit 09e0643 into quarkusio:main Apr 7, 2025
2 checks passed
@dmlloyd dmlloyd deleted the generics branch April 7, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
2.x Issue applies to Gizmo 2.x
Projects
WG - Gizmo 2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gizmo2: Revisit generic arguments usage
2 participants
@dmlloyd @Ladicek