fix the ArrayStore item #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ArrayStore` item used to emit an array store instruction based on the type kind of the array, which is always reference. It needs to do that based on the type kind of the _component type_ of the array. Further, this commit replaces all occurences of "element type" with "component type", because that's what they really are. This doesn't make a difference with single-dimensional arrays, which is the vast majority of arrays, but it does make a difference with multi-dimensional arrays, where component type is the type of the inner array, while the element type is never an array type. Finally, some tests for arrays are added.
Ladicek
commented
Mar 28, 2025
| @@ -32,6 +36,6 @@ protected Node forEachDependency(final Node node, final BiFunction<Item, Node, N | |||
| } | |||
|
|
|||
| public void writeCode(final CodeBuilder cb, final BlockCreatorImpl block) { | |||
| cb.arrayStore(arrayExpr.typeKind()); | |||
| cb.arrayStore(TypeKind.from(componentType)); | |||
There was a problem hiding this comment.
This is the actual bugfix. The rest of this commit is cleanup :-)
mkouba
approved these changes
Mar 28, 2025
|
Agree that 2 variants accepting |
|
I would add an explicit |
|
Ok, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ArrayStoreitem used to emit an array store instruction based on the type kind of the array, which is always reference. It needs to do that based on the type kind of the component type of the array.Further, this commit replaces all occurences of "element type" with "component type", because that's what they really are. This doesn't make a difference with single-dimensional arrays, which is the vast majority of arrays, but it does make a difference with multi-dimensional arrays, where component type is the type of the inner array, while the element type is never an array type.
Finally, some tests for arrays are added.