Gizmo2: fix BlockCreator#unbox() #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah there's a couple things that you have to do explicitly in current state of Gizmo 2 (boxing/unboxing, but also capturing variables in lambdas/anonymous classes) that were implicit in Gizmo 1. Not sure how I feel about that. |
Ladicek
reviewed
Mar 26, 2025
Comment on lines
+77
to
+78
| // WORKAROUND: we need to use local vars for types where unboxing involves cmp/cmpg | ||
| // TODO: file a new issue |
Ladicek
reviewed
Mar 26, 2025
Ladicek
approved these changes
Mar 26, 2025
We can definitely improve some of that. I just went for the shortest path to completion in a lot of cases. I think we could probably implement decent autoboxing/unboxing though. |
dmlloyd
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure how to work with primitive types that cannot be represented directly in the constant pool (
byte,short,char). So the test is not complete.NOTE: In Gizmo1, we have some autoboxing functionality implemented. It might make sense to consider something similar in Gizmo2. @Ladicek knows probably more...