Skip to content

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 25, 2025

No description provided.

@mkouba mkouba moved this to Todo in WG - Gizmo 2 Mar 26, 2025
@mkouba mkouba marked this pull request as ready for review March 26, 2025 18:45
@mkouba
Copy link
Contributor Author

mkouba commented Mar 26, 2025

@dmlloyd The test passed but I can still see the GETFIELD op in the constructor:

- method name: <init>
        flags: []
        method type: ()V
        attributes: [Code]
        code: 
            max stack: 2
            max locals: 1
            attributes: []
            //stack map frame @0: {locals: [THIS], stack: []}
            0: {opcode: ALOAD_0, slot: 0}
            1: {opcode: INVOKESPECIAL, owner: java/lang/Object, method name: <init>, method type: ()V}
            4: {opcode: ALOAD_0, slot: 0}
            5: {opcode: GETFIELD, owner: io/quarkus/gizmo2/Alpha, field name: bravo, field type: Ljava/lang/String;}
            8: {opcode: LDC, constant value: charlie}
            10: {opcode: PUTFIELD, owner: io/quarkus/gizmo2/Alpha, field name: bravo, field type: Ljava/lang/String;}
            13: {opcode: RETURN}

@dmlloyd
Copy link
Member

dmlloyd commented Mar 26, 2025

I don't see that locally:

      - method name: <init>
        flags: []
        method type: ()V
        attributes: [Code]
        code: 
            max stack: 2
            max locals: 1
            attributes: []
            //stack map frame @0: {locals: [THIS], stack: []}
            0: {opcode: ALOAD_0, slot: 0}
            1: {opcode: INVOKESPECIAL, owner: java/lang/Object, method name: <init>, method type: ()V}
            4: {opcode: ALOAD_0, slot: 0}
            5: {opcode: LDC, constant value: charlie}
            7: {opcode: PUTFIELD, owner: io/quarkus/gizmo2/Alpha, field name: bravo, field type: Ljava/lang/String;}
            10: {opcode: RETURN}

@dmlloyd dmlloyd merged commit f6cc593 into quarkusio:2.x Mar 26, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in WG - Gizmo 2 Mar 26, 2025
@dmlloyd
Copy link
Member

dmlloyd commented Mar 26, 2025

We can just follow up with another issue if something is still weird.

@mkouba
Copy link
Contributor Author

mkouba commented Mar 27, 2025

We can just follow up with another issue if something is still weird.

👍 totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants