Complete rework of switch
#247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 18, 2025
Fixes quarkusio#228, quarkusio#244, part of quarkusio#237
mkouba
reviewed
Mar 19, 2025
| @@ -1,6 +1,6 @@ | |||
| package io.quarkus.gizmo2.creator; | |||
|
|
|||
| import static java.lang.constant.ConstantDescs.CD_boolean; | |||
| import static java.lang.constant.ConstantDescs.*; | |||
There was a problem hiding this comment.
I think that we should not use the * imports. In fact, gizmo should probably use the same rules as Quarkus.
There was a problem hiding this comment.
I agree for class imports. For static imports, especially for classes like this which are designed to be used in this way, I disagree. It seems pointless to expand them all out in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228, #244, part of #237