Clarify docstring of is_parameterized
#7215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7215 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1104 1104
Lines 96352 96352
==========================================
- Hits 94569 94565 -4
- Misses 1783 1787 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daxfohl
approved these changes
Apr 2, 2025
mhucka
approved these changes
Apr 2, 2025
| @@ -67,7 +67,7 @@ def is_parameterized(val: Any) -> bool: | |||
|
|
|||
| A value is parameterized when it has an `_is_parameterized_` method and | |||
| that method returns a truthy value, or if the value is an instance of | |||
| sympy.Basic. | |||
| sympy.Basic. Note this covers sympy constants such as `sympy.pi`. | |||
There was a problem hiding this comment.
Tiny nit that can be ignored: I would perhaps change that line to
`sympy.Basic`. Note this covers SymPy constants such as `sympy.pi`.
but really, looking at the rest of the file, it has other places where capitalization and backticks are inconsistent, so it could be left to some later sweep to deal with such nonessential things.
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7053