Resolve issue #7000 by adding PR size-labeling GitHub Actions workflow #7203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This size labeling workflow should be a close approximation to what CirqBot currently does via `pr_monitor`. Once in place, it should be possible to remove pr_monitor from the Cirq code base, because the automerge functionality of pr_monitor (which is the other thing that it did) is now implemented using GitHub's merge queues. This basically resolves quantumlib#7000.
|
Related issue: #6024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7203 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 1100 1100
Lines 96244 96244
=======================================
Hits 94462 94462
Misses 1782 1782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
reviewed
Mar 31, 2025
.github/workflows/pr-labeler.yaml
Outdated
Comment on lines
63
to
79
| The size of this pull request exceeds 1000 additions and/or | ||
| deletions. Extra large pull requests like this are more difficult | ||
| to review, and sometimes their large size signals that they could | ||
| be restructured. Please check the following: | ||
|
|
||
| - [ ] Are the git commits in this PR limited to what's needed? Or | ||
| is it possible that other commits were included accidentally? | ||
|
|
||
| - [ ] Does this PR only address one issue, feature, problem, or | ||
| topic? Or are multiple issues or changes mixed together? | ||
|
|
||
| Sometimes large commits really are needed, and that's okay! | ||
| Examples include reformatting code using an automated tool, | ||
| refactoring code, and adding generated code. At other times, a | ||
| large PR could benefit by reconsidering it in light of the [Small | ||
| CLs](https://google.github.io/eng-practices/review/developer/small-cls.html) | ||
| principles. |
There was a problem hiding this comment.
Let us take this out, the advice can be spammy for experienced developers.
New contributors are less likely to produce an XL PR. Either of those need to
be human-reviewed and we can ask to split such PRs where it makes sense.
There was a problem hiding this comment.
Let us take this out, the advice can be spammy for experienced developers. New contributors are less likely to produce an XL PR. Either of those need to be human-reviewed and we can ask to split such PRs where it makes sense.
Yeah, you're right. Taking it out.
pavoljuhas
requested changes
Mar 31, 2025
Review comments led to the conclusion that the message is unnecessary and more likely to be annoying than helpfu.
pavoljuhas
approved these changes
Apr 1, 2025
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…ib#7203) * Add PR labeler workflow with size labeling (for now) This size labeling workflow should be a close approximation to what CirqBot currently does via `pr_monitor`. Once in place, it should be possible to remove pr_monitor from the Cirq code base, because the automerge functionality of pr_monitor (which is the other thing that it did) is now implemented using GitHub's merge queues. This basically resolves quantumlib#7000. * Remove message for XL changes Review comments led to the conclusion that the message is unnecessary and more likely to be annoying than helpfu.
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow adds automatic labeling of sizes of PRs. It's configured to use
the same labels we use in Cirq (e.g.,
size: M,size: L, etc.) and thebehavior should be a close approximation to what CirqBot currently does via
pr_monitor. Once in place, it should then be possible to removepr_monitorfrom the Cirq code base, because its automerge functionality (which is the
other thing that it did) is now done using GitHub's merge queues.
This basically resolves #7000 and #6935.