Remove previously deprecated fields in cirq_google proto #7183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Mar 25, 2025
- Removes schedule (not used in 5+ years)
- Removes gate and args (not used since v2.5, 3+ years)
- Removes checks on gate set and language.
- Removes tests that use the above.
- Removes schedule (not used in 5+ years) - Removes gate and args (not used since v2.5, 3+ years) - Removes checks on gate set and language. - Removes tests that use the above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7183 +/- ##
==========================================
- Coverage 98.66% 98.65% -0.01%
==========================================
Files 1106 1106
Lines 95914 95870 -44
==========================================
- Hits 94630 94583 -47
- Misses 1284 1287 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
These fields are still used by Quantum Engine. Please see b/406240865 for more details and to track cleanup work. |
pavoljuhas
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
LGTM for Cirq, please hold this for a green light from wcourtney.
PS: protofmt found some nits -
diff --git a/cirq-google/cirq_google/api/v2/program.proto b/cirq-google/cirq_google/api/v2/program.proto
index 7bc27788..d90ec97c 100644
--- a/cirq-google/cirq_google/api/v2/program.proto
+++ b/cirq-google/cirq_google/api/v2/program.proto
@@ -206,3 +206,3 @@ message Operation {
// Previously deprecated fields. Do not use.
- reserved 1,2;
+ reserved 1, 2;
@@ -235,3 +235,3 @@ message Operation {
// will only be populated in v2.5+
- repeated Qubit qubits = 3 [deprecated=true];
+ repeated Qubit qubits = 3 [deprecated = true];
repeated int32 qubit_constant_index = 6;
|
@wcourtney Are we good to submit this now? |
Yes, the uses of these protos have been removed and pushed to prod. |
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…7183) * Remove previously deprecated fields in cirq_google proto - Removes schedule (not used in 5+ years) - Removes gate and args (not used since v2.5, 3+ years) - Removes checks on gate set and language. - Removes tests that use the above. * Take care of deprecated usage in test. * Another broken test. * Remove another test * Remove engine test with bad gateset * Put back test. * Add back lint issue. --------- Co-authored-by: Pavol Juhas <juhas@google.com>
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.