Skip to content

Fix deserialization of reset gates when dimensions missing. #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Fix deserialization of reset gates when dimensions missing. #7135

merged 2 commits into from
Mar 11, 2025

Conversation

dstrain115
Copy link
Collaborator

  • If dimensions is missing, it should be set to 2.
  • However, the previous code passed 2 to arg_from_proto.
  • 2 is not a proto, it's a number, so this did not work.

@dstrain115
Fix deserialization of reset gates when dimensions missing.
189e32e 
- If dimensions is missing, it should be set to 2.
- However, the previous code passed 2 to arg_from_proto.
- 2 is not a proto, it's a number, so this did not work.
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners March 10, 2025 22:53
@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 10, 2025
@pavoljuhas
Copy link
Collaborator

CI coverage should be fixed by #7137

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (5e7bc33) to head (b3ee6cb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7135   +/-   ##
=======================================
  Coverage   98.15%   98.16%           
=======================================
  Files        1093     1093           
  Lines       95455    95466   +11     
=======================================
+ Hits        93695    93710   +15     
+ Misses       1760     1756    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dstrain115 dstrain115 added this pull request to the merge queue Mar 11, 2025
Merged via the queue into quantumlib:main with commit 8073d4c Mar 11, 2025
38 checks passed
@dstrain115 dstrain115 deleted the fix_serialization_arg_oopsies branch March 11, 2025 16:23
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
@dstrain115 @BichengYing
Fix deserialization of reset gates when dimensions missing. (quantuml…
a6a8845 
…ib#7135)

- If dimensions is missing, it should be set to 2.
- However, the previous code passed 2 to arg_from_proto.
- 2 is not a proto, it's a number, so this did not work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @pavoljuhas @CirqBot