Allow symbolic scalars in linear combinations #7030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7030 +/- ##
==========================================
- Coverage 97.89% 97.88% -0.01%
==========================================
Files 1085 1085
Lines 95188 95199 +11
==========================================
+ Hits 93181 93190 +9
- Misses 2007 2009 +2 ☔ View full report in Codecov by Sentry. |
|
@pavoljuhas is there a workaround for the coverage check on |
pavoljuhas
reviewed
Feb 6, 2025
pavoljuhas
approved these changes
Feb 6, 2025
This gets fixed by moving coverage configuration to pyproject.toml - #7038 (comment) |
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Parameterize LinearDict * Add protocol handlers * fix protocol handlers * fix protocol handlers, add test * format * tests * Y, Z gates, parameterize test * mypy * Revert changes to Scalar, and just use TParamValComplex everywhere. Add tests. * Parameterize LinearCombinationOfGates * tests * tests * tests * tests * test * Update cirq-core/cirq/ops/raw_types.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> --------- Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #7003, allowing symbolic scalars in
LinearCombinationOfGatesandLinearCombinationOfOps.Applies to #1617.