Allow symbolic scalars in LinearDict #7003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
commented
Jan 30, 2025
| @@ -423,6 +465,7 @@ def test_unequal(terms_1, terms_2): | |||
| ({'X': 1e-12}, {'X': 0}), | |||
| ({'X': 5e-10}, {'Y': 2e-11}), | |||
| ({'X': 1.000000001}, {'X': 1, 'Z': 0}), | |||
| ({'X': sym + 0.000000001}, {'X': sym}), | |||
There was a problem hiding this comment.
I was impressed that approximate equality worked out of the box. No special handling required.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7003 +/- ##
==========================================
- Coverage 97.89% 97.89% -0.01%
==========================================
Files 1085 1085
Lines 95132 95184 +52
==========================================
+ Hits 93127 93176 +49
- Misses 2005 2008 +3 ☔ View full report in Codecov by Sentry. |
pavoljuhas
approved these changes
Feb 3, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Parameterize LinearDict * Add protocol handlers * fix protocol handlers * fix protocol handlers, add test * format * tests * Y, Z gates, parameterize test * mypy * Revert changes to Scalar, and just use TParamValComplex everywhere. Add tests. * nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows symbolic scalars in LinearDict, plus implementations of Pauli expansions for symbolic exponents in X, Y, and Z gates.
Applies to #1617. Resolves the core issue, though there are follow up tasks to update remaining gates
_pauli_expansion_methods, and then alsoPauliSumandLinearCombinationOfGates/Ops, along with the functions that create these classes, to accept or handle parameters.