Skip to content

Add clarification to GridQubit neighbors function #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Add clarification to GridQubit neighbors function #7521

merged 2 commits into from
Jul 21, 2025

Conversation

dstrain115
Copy link
Collaborator

  • An internal bug noted that there could be confusion if you assumed that GridQubit.neighbors() returned only the neighbors on a specific device layout.
  • This changes only the documentation to point out that this function is device-agnostic.

@dstrain115
Add clarification to GridQubit neighbors function
44a0c4c 
- An internal bug noted that there could be confusion if
you assumed that GridQubit.neighbors() returned only the
neighbors on a specific device layout.
- This changes only the documentation to point out that this
function is device-agnostic.
@dstrain115 dstrain115 requested review from vtomole and a team as code owners July 21, 2025 13:34
@github-actions github-actions bot added the size: S 10< lines changed <50 label Jul 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (c434f94) to head (d1aaf58).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7521      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1091     1091              
  Lines       96948    96948              
==========================================
- Hits        95674    95673       -1     
- Misses       1274     1275       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pavoljuhas
pavoljuhas reviewed Jul 21, 2025
View reviewed changes
@dstrain115 @pavoljuhas
Update cirq-core/cirq/devices/grid_qubit.py
d1aaf58 
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
@dstrain115 dstrain115 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into quantumlib:main with commit 11c769d Jul 21, 2025
35 checks passed
@dstrain115 dstrain115 deleted the grid_neighbors_docs branch July 21, 2025 21:26
This was referenced Aug 5, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton MichaelBroughton is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstrain115 @pavoljuhas