Skip to content

Fix missing None types on test functions #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix missing None types on test functions #7494

merged 1 commit into from
Jul 15, 2025

Conversation

dstrain115
Copy link
Collaborator

  • Noticed that these functions were throwing warnings since there are type annotations defined but the return type was not defined.

@dstrain115
Fix missing None types on test functions
6cbc55b 
- Noticed that these functions were throwing warnings
since there are type annotations defined but the return type
was not defined.
@github-actions github-actions bot added the Size: XS <10 lines changed label Jul 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (89ebad8) to head (6cbc55b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7494      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1092     1091       -1     
  Lines       96855    96851       -4     
==========================================
- Hits        95583    95578       -5     
- Misses       1272     1273       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dstrain115 dstrain115 marked this pull request as ready for review July 15, 2025 18:27
@dstrain115 dstrain115 requested review from wcourtney, vtomole, verult and a team as code owners July 15, 2025 18:27
@dstrain115 dstrain115 requested a review from BichengYing July 15, 2025 18:27
vtomole
vtomole approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstrain115 dstrain115 added this pull request to the merge queue Jul 15, 2025
Merged via the queue into quantumlib:main with commit 40722be Jul 15, 2025
35 checks passed
@dstrain115 dstrain115 deleted the add_missing_types_analog branch July 15, 2025 18:53
This was referenced Aug 5, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@BichengYing BichengYing BichengYing approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @vtomole @BichengYing